From: Tomasz Marciniak <t.marciniak@samsung.com>
Date: Tue, 6 Oct 2015 13:35:57 +0000 (+0200)
Subject: [Messaging] Remove unnecessary TODO sections.
X-Git-Tag: submit/tizen/20151026.073646^2^2~42^2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c9f1afe04573156c2d9f919ac9ece707529023a9;p=platform%2Fcore%2Fapi%2Fwebapi-plugins.git

[Messaging] Remove unnecessary TODO sections.

[Verification] Code compiles. TCT pass rate 100%

Change-Id: I2f0e370cee7593600a57f1a9bd23108b4869e75d
Signed-off-by: Tomasz Marciniak <t.marciniak@samsung.com>
---

diff --git a/src/messaging/DBus/LoadBodyProxy.cpp b/src/messaging/DBus/LoadBodyProxy.cpp
index e6dfeaaa..395ce78c 100644
--- a/src/messaging/DBus/LoadBodyProxy.cpp
+++ b/src/messaging/DBus/LoadBodyProxy.cpp
@@ -154,34 +154,13 @@ void LoadBodyProxy::handleEmailSignal(const int status,
                 email_mail_data_t* mail_data = EmailManager::loadMessage(
                          callback->getMessage()->getId());
                 if (mail_data) {
+                    //attachments are updated indirectly by updateEmailMessage()
                     ret = callback->getMessage()->updateEmailMessage(*mail_data);
                     if (!ret.IsError()) {
                         EmailManager::freeMessage(mail_data);
                         mail_data = NULL;
                     }
                 }
-
-                //TODO: this should be reviewed when attachments and
-                //      loadAttachments have been completed.
-                //TODO: see old implementation lines 608-635 in MailSync.cpp
-                //
-                // This is original Messaging implementation:
-                //
-                // std::vector<IAttachmentPtr> attachments = mail->getAttachments();
-                // std::vector<IAttachmentPtr> inlineAttachments = mail->getInlineAttachments();
-                //
-                // for (unsigned int idx = 0; idx < attachments.size() ; idx++ )
-                // {
-                //   LoggerD("set Attachment ID = " << attachments[idx]->getAttachmentID());
-                //   attachments[idx]->setMessage(event->m_message);
-                //
-                // }
-                // for (unsigned int idx = 0; idx < inlineAttachments.size() ; idx++ )
-                // {
-                //   LoggerD("set inline Attachment ID = " << inlineAttachments[idx]->getAttachmentID());
-                //   inlineAttachments[idx]->setMessage(event->m_message);
-                // }
-                //
             }
 
             if (!ret.IsError()) {
diff --git a/src/messaging/message_mms.cc b/src/messaging/message_mms.cc
index edd0e914..8e621bbd 100755
--- a/src/messaging/message_mms.cc
+++ b/src/messaging/message_mms.cc
@@ -79,7 +79,6 @@ void MessageMMS::setMessageAttachments(AttachmentPtrVector &attachments)
 bool MessageMMS::getHasAttachment() const
 {
     LoggerD("MessageMMS::getHasAttachment()");
-    // TODO: Analyze relation between hasAttachment flag and inlineAttachments
     return m_has_attachment;
 }
 
diff --git a/src/messaging/messaging_manager.cc b/src/messaging/messaging_manager.cc
index 4c119e57..32e45d47 100755
--- a/src/messaging/messaging_manager.cc
+++ b/src/messaging/messaging_manager.cc
@@ -125,7 +125,6 @@ static void* getMsgServicesThread(const std::shared_ptr<MsgManagerCallbackData>&
           } else {
             *(user_data->sms_service) = std::make_pair(service->getMsgServiceId(), service);
 
-            // TODO FIXME
             picojson::array array;
             array.push_back(picojson::value(service->toPicoJS()));
             obj[JSON_DATA] = picojson::value(array);
@@ -169,7 +168,6 @@ static void* getMsgServicesThread(const std::shared_ptr<MsgManagerCallbackData>&
           email_account_t* email_accounts = nullptr;
           int count = 0;
 
-          // TODO FIXME need to work on readability of that case
           if (email_get_account_list(&email_accounts, &count) != EMAIL_ERROR_NONE) {
             LoggerE("Method failed: email_get_account_list()");
             platform_result = PlatformResult(ErrorCode::UNKNOWN_ERR, "Error during getting account list");
diff --git a/src/messaging/messaging_util.cc b/src/messaging/messaging_util.cc
index 8d443eb8..1ee370ab 100755
--- a/src/messaging/messaging_util.cc
+++ b/src/messaging/messaging_util.cc
@@ -751,7 +751,6 @@ PlatformResult MessagingUtil::jsonToMessage(const picojson::value& json,
             int mail_id = std::atoi(mid.c_str());
             email_mail_data_t* mail = NULL;
             if (EMAIL_ERROR_NONE != email_get_mail_data(mail_id, &mail)) {
-                // TODO what should happen?
                 LoggerE("Fatal error: message not found: %d!", mail_id);
                 return PlatformResult(ErrorCode::TYPE_MISMATCH_ERR,
                                       "Failed to find specified email.");