From: Piotr Kosko/Tizen API (PLT) /SRPOL/Engineer/Samsung Electronics Date: Tue, 18 May 2021 11:02:27 +0000 (+0200) Subject: [mediacontroller] Fixing Coverity issues X-Git-Tag: submit/tizen/20210609.101925~4^2~1 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c9edc16da7f5ec9b4a0d1159968a5f5792301710;p=platform%2Fcore%2Fapi%2Fwebapi-plugins.git [mediacontroller] Fixing Coverity issues Fixes: 1192721 Change-Id: I1bd564b935d35f0586e174869f7df10cd0cc705b --- diff --git a/src/mediacontroller/mediacontroller_server.cc b/src/mediacontroller/mediacontroller_server.cc index 87c6bb79..cd6b1ead 100644 --- a/src/mediacontroller/mediacontroller_server.cc +++ b/src/mediacontroller/mediacontroller_server.cc @@ -539,6 +539,11 @@ PlatformResult MediaControllerServer::CreatePlaylist(const std::string& serverNa mc_playlist_h& playlist_handle) { ScopeLogger(); + if (playlist_info == nullptr) { + return LogAndCreateResult(ErrorCode::UNKNOWN_ERR, + "Unable to createPlaylist", + ("playlist_info is nullptr")); + } mc_playlist_h playlist_handle_ = nullptr; std::lock_guard lock(handle_mutex_); @@ -552,11 +557,6 @@ PlatformResult MediaControllerServer::CreatePlaylist(const std::string& serverNa playlist_handle = playlist_handle_; - if (playlist_info == nullptr) { - return LogAndCreateResult(ErrorCode::UNKNOWN_ERR, "Unable to createPlaylist", - ("playlist_info is nullptr")); - } - *playlist_info = picojson::value(picojson::object()); picojson::object& obj = playlist_info->get(); obj[kName] = picojson::value(name);