From: Eric Paris Date: Mon, 29 Nov 2010 20:46:39 +0000 (-0500) Subject: SELinux: do not set automatic i_ino in selinuxfs X-Git-Tag: v2.6.38-rc1~429^2^2~7 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c9e86a9b95f198d7df49b25fcd808ee39cba218f;p=profile%2Fivi%2Fkernel-adaptation-intel-automotive.git SELinux: do not set automatic i_ino in selinuxfs selinuxfs carefully uses i_ino to figure out what the inode refers to. The VFS used to generically set this value and we would reset it to something useable. After 85fe4025c616 each filesystem sets this value to a default if needed. Since selinuxfs doesn't use the default value and it can only lead to problems (I'd rather have 2 inodes with i_ino == 0 than one pointing to the wrong data) lets just stop setting a default. Signed-off-by: Eric Paris Acked-by: James Morris --- diff --git a/security/selinux/selinuxfs.c b/security/selinux/selinuxfs.c index 8bae68e..45d35e6 100644 --- a/security/selinux/selinuxfs.c +++ b/security/selinux/selinuxfs.c @@ -989,7 +989,6 @@ static struct inode *sel_make_inode(struct super_block *sb, int mode) struct inode *ret = new_inode(sb); if (ret) { - ret->i_ino = get_next_ino(); ret->i_mode = mode; ret->i_atime = ret->i_mtime = ret->i_ctime = CURRENT_TIME; }