From: Sven Eckelmann Date: Sat, 5 Mar 2016 15:09:20 +0000 (+0100) Subject: batman-adv: Use kref_get for batadv_tvlv_container_get X-Git-Tag: v4.7-rc1~154^2~72^2~8 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c9dad805e9f4fd3978f22c970bae49eaa00b46dd;p=platform%2Fkernel%2Flinux-exynos.git batman-adv: Use kref_get for batadv_tvlv_container_get batadv_tvlv_container_get requires that tvlv.container_list_lock is held by the caller. It is therefore not possible that an item in tvlv.container_list has an reference counter of 0 and is still in the list The kref_get function instead WARNs (with debug information) when the reference counter would still be 0. This makes a bug in batman-adv better visible because kref_get_unless_zero would have ignored this problem. Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli --- diff --git a/net/batman-adv/main.c b/net/batman-adv/main.c index c8d8bc7..5f2974b 100644 --- a/net/batman-adv/main.c +++ b/net/batman-adv/main.c @@ -748,9 +748,7 @@ batadv_tvlv_container_get(struct batadv_priv *bat_priv, u8 type, u8 version) if (tvlv_tmp->tvlv_hdr.version != version) continue; - if (!kref_get_unless_zero(&tvlv_tmp->refcount)) - continue; - + kref_get(&tvlv_tmp->refcount); tvlv = tvlv_tmp; break; }