From: Oliver Hartkopp Date: Mon, 18 Mar 2013 07:52:06 +0000 (+0000) Subject: can: dump stack on protocol bugs X-Git-Tag: v3.10-rc1~66^2~431 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c9bbb75f1dffef0e6ac47abf32cdb668d5e1a867;p=platform%2Fkernel%2Flinux-stable.git can: dump stack on protocol bugs The rework of the kernel hlist implementation "hlist: drop the node parameter from iterators" (b67bfe0d42cac56c512dd5da4b1b347a23f4b70a) created some fallout in the form of non matching comments and obsolete code. Additionally to the cleanup this patch adds a WARN() statement to catch the caller of the wrong filter removal request. Signed-off-by: Oliver Hartkopp Signed-off-by: David S. Miller --- diff --git a/net/can/af_can.c b/net/can/af_can.c index 8bacf28..c4e5085 100644 --- a/net/can/af_can.c +++ b/net/can/af_can.c @@ -546,16 +546,13 @@ void can_rx_unregister(struct net_device *dev, canid_t can_id, canid_t mask, } /* - * Check for bugs in CAN protocol implementations: - * If no matching list item was found, the list cursor variable next - * will be NULL, while r will point to the last item of the list. + * Check for bugs in CAN protocol implementations using af_can.c: + * 'r' will be NULL if no matching list item was found for removal. */ if (!r) { - pr_err("BUG: receive list entry not found for " - "dev %s, id %03X, mask %03X\n", - DNAME(dev), can_id, mask); - r = NULL; + WARN(1, "BUG: receive list entry not found for dev %s, " + "id %03X, mask %03X\n", DNAME(dev), can_id, mask); goto out; }