From: Sangchul Lee <sc11.lee@samsung.com>
Date: Thu, 10 Oct 2024 22:45:09 +0000 (+0900)
Subject: webrtc_source_loopback: Check the return value of gst_bin_add()
X-Git-Tag: accepted/tizen/unified/20241017.114714~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c98fc7ad45ae7ce8e0a981d83ff33eb97fe500a1;p=platform%2Fcore%2Fapi%2Fwebrtc.git

webrtc_source_loopback: Check the return value of gst_bin_add()

[Version] 1.1.36
[Issue Type] Coverity defect

Change-Id: I220c49e058ee0ac90da7e499bb701f397005b615
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
---

diff --git a/packaging/capi-media-webrtc.spec b/packaging/capi-media-webrtc.spec
index 3e0afd34..5ccc6fc9 100644
--- a/packaging/capi-media-webrtc.spec
+++ b/packaging/capi-media-webrtc.spec
@@ -1,6 +1,6 @@
 Name:       capi-media-webrtc
 Summary:    A WebRTC library in Tizen Native API
-Version:    1.1.35
+Version:    1.1.36
 Release:    0
 Group:      Multimedia/API
 License:    Apache-2.0
diff --git a/src/webrtc_source_loopback.c b/src/webrtc_source_loopback.c
index 83401ee8..9089b704 100644
--- a/src/webrtc_source_loopback.c
+++ b/src/webrtc_source_loopback.c
@@ -295,7 +295,11 @@ static int __build_loopback_render_pipeline(webrtc_s *webrtc, webrtc_gst_slot_s
 	} else {
 		int ret = WEBRTC_ERROR_NONE;
 
-		gst_bin_add(GST_BIN(source->av[idx].render.pipeline), appsrc);
+		if (!gst_bin_add(GST_BIN(source->av[idx].render.pipeline), appsrc)) {
+			LOG_ERROR("failed to gst_bin_add(), adding [%s] to [%s]", GST_ELEMENT_NAME(appsrc), GST_ELEMENT_NAME(source->av[idx].render.pipeline));
+			gst_object_unref(GST_OBJECT(appsrc));
+			goto error;
+		}
 
 		if (type == MEDIA_TYPE_AUDIO)
 			ret = __build_loopback_audiosink(source, appsrc);