From: Markus Lehtonen <markus.lehtonen@linux.intel.com>
Date: Fri, 15 Jun 2012 05:43:12 +0000 (+0300)
Subject: import-orig: simplify repack_source() and tmpdir handling
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c94f9baf106c70c33a2cfb27b2562c9e7006821c;p=tools%2Fgit-buildpackage.git

import-orig: simplify repack_source() and tmpdir handling

Now a tmpdir is always created and sources are always unpacked into
there.

Signed-off-by: Markus Lehtonen <markus.lehtonen@linux.intel.com>
---

diff --git a/gbp/scripts/common/import_orig.py b/gbp/scripts/common/import_orig.py
index d36804f3..0dff2022 100644
--- a/gbp/scripts/common/import_orig.py
+++ b/gbp/scripts/common/import_orig.py
@@ -126,18 +126,15 @@ def repacked_tarball_name(source, name, version):
     return name
 
 
-def repack_source(source, name, version, tmpdir, filters):
+def repack_source(source, name, version, unpack_dir, filters):
     """Repack the source tree"""
     name = repacked_tarball_name(source, name, version)
     repacked = source.pack(name, filters)
     if source.is_orig(): # the tarball was filtered on unpack
         repacked.unpacked = source.unpacked
     else: # otherwise unpack the generated tarball get a filtered tree
-        if tmpdir:
-            cleanup_tmp_tree(tmpdir)
-        tmpdir = tempfile.mkdtemp(dir='../')
-        repacked.unpack(tmpdir, filters)
-    return (repacked, tmpdir)
+        repacked.unpack(unpack_dir, filters)
+    return repacked
 
 
 def download_orig(url):
diff --git a/gbp/scripts/import_orig.py b/gbp/scripts/import_orig.py
index 69e076ab..fb041101 100644
--- a/gbp/scripts/import_orig.py
+++ b/gbp/scripts/import_orig.py
@@ -288,7 +288,7 @@ def parse_args(argv):
 
 def main(argv):
     ret = 0
-    tmpdir = ''
+    tmpdir = tempfile.mkdtemp(dir='../')
     pristine_orig = None
     linked = False
 
@@ -333,13 +333,14 @@ def main(argv):
             set_bare_repo_options(options)
 
         if not source.is_dir():
-            tmpdir = tempfile.mkdtemp(dir='../')
-            source.unpack(tmpdir, options.filters)
+            unpack_dir = tempfile.mkdtemp(prefix='unpack', dir=tmpdir)
+            source.unpack(unpack_dir, options.filters)
             gbp.log.debug("Unpacked '%s' to '%s'" % (source.path, source.unpacked))
 
         if orig_needs_repack(source, options):
             gbp.log.debug("Filter pristine-tar: repacking '%s' from '%s'" % (source.path, source.unpacked))
-            (source, tmpdir)  = repack_source(source, sourcepackage, version, tmpdir, options.filters)
+            repack_dir = tempfile.mkdtemp(prefix='repack', dir=tmpdir)
+            source = repack_source(source, sourcepackage, version, repack_dir, options.filters)
 
         (pristine_orig, linked) = prepare_pristine_tar(source.path,
                                                        sourcepackage,