From: Piotr Kosko <p.kosko@samsung.com>
Date: Mon, 27 Jun 2016 08:56:23 +0000 (+0200)
Subject: [Preference] Additional check for unsetChangeListener NotFoundErr
X-Git-Tag: submit/tizen/20160627.095720~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c941f8937d1da35b65e99126856664d1d96feec6;p=platform%2Fcore%2Fapi%2Fwebapi-plugins.git

[Preference] Additional check for unsetChangeListener NotFoundErr

[Feature] Handling NotFoundErr was added in unsetChangeListener()

[Verification] TCT passrate is 97.73% (1 fail caused by TCT issue)

Change-Id: I48be34dbac09ccfd119da2ff400911b7e8e4c0f5
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
---

diff --git a/src/preference/preference_manager.cc b/src/preference/preference_manager.cc
index b9760040..2461f3fb 100644
--- a/src/preference/preference_manager.cc
+++ b/src/preference/preference_manager.cc
@@ -285,14 +285,13 @@ common::TizenResult PreferenceManager::UnsetChangeListener(const std::string& ke
         if (PREFERENCE_ERROR_NONE != ret) {
           return MakeErrResult(ret, "preference_unset_changed_cb function error");
         }
-
         key_listeners_.erase(it);
-        break;
+        return common::TizenSuccess();
       }
     }
   }
-
-  return common::TizenSuccess();
+  // key was not found
+  return common::NotFoundError(std::string("Listener for given key was not found"));
 }
 
 } // namespace preference