From: Mike Mason Date: Tue, 30 Jun 2009 12:45:53 +0000 (+0000) Subject: e1000e: io_error_detected callback should return PCI_ERS_RESULT_DISCONNECT X-Git-Tag: v2.6.31-rc2~26^2~2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c93b5a76d58656158d195a7df507ebc660010969;p=platform%2Fupstream%2Fkernel-adaptation-pc.git e1000e: io_error_detected callback should return PCI_ERS_RESULT_DISCONNECT on permanent failure PCI drivers that implement the io_error_detected callback should return PCI_ERS_RESULT_DISCONNECT if the state passed in is pci_channel_io_perm_failure. This state is not checked in many of the network drivers. This patch fixes the omission in the e1000e driver. Signed-off-by: Mike Mason Signed-off-by: Jeff Kirsher Signed-off-by: David S. Miller --- diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c index 679885a..63415bb 100644 --- a/drivers/net/e1000e/netdev.c +++ b/drivers/net/e1000e/netdev.c @@ -4785,6 +4785,9 @@ static pci_ers_result_t e1000_io_error_detected(struct pci_dev *pdev, netif_device_detach(netdev); + if (state == pci_channel_io_perm_failure) + return PCI_ERS_RESULT_DISCONNECT; + if (netif_running(netdev)) e1000e_down(adapter); pci_disable_device(pdev);