From: Philip Withnall <philip.withnall@collabora.co.uk>
Date: Tue, 31 Aug 2010 15:31:56 +0000 (+0100)
Subject: Don't set Individual.is-favourite when updating from Personas
X-Git-Tag: FOLKS_0_1_16~2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c905237fd9d215ee2a90f423101d7d20c604c8c5;p=platform%2Fupstream%2Ffolks.git

Don't set Individual.is-favourite when updating from Personas

Set the private Individual._is_favourite member instead, to prevent the new
favourite status from being pushed down to all the Personas and stomping all
over their favourite statuses. See also: bgo#628131
---

diff --git a/folks/individual.vala b/folks/individual.vala
index f8c7f0b..d20bc3d 100644
--- a/folks/individual.vala
+++ b/folks/individual.vala
@@ -495,9 +495,14 @@ public class Folks.Individual : Object,
             }
         });
 
-      /* Only notify if the value has changed */
-      if (this.is_favourite != favourite)
-        this.is_favourite = favourite;
+      /* Only notify if the value has changed. We have to set the private member
+       * and notify manually, or we'd end up propagating the new favourite
+       * status back down to all our Personas. */
+      if (this._is_favourite != favourite)
+        {
+          this._is_favourite = favourite;
+          this.notify_property ("is-favourite");
+        }
     }
 
   private void update_alias ()