From: GUO Zihua Date: Fri, 2 Sep 2022 08:15:21 +0000 (+0800) Subject: net: lantiq_etop: Fix return type for implementation of ndo_start_xmit X-Git-Tag: v6.1-rc5~319^2~272 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c8ef3c94bda0e21123202d057d4a299698fa0ed9;p=platform%2Fkernel%2Flinux-starfive.git net: lantiq_etop: Fix return type for implementation of ndo_start_xmit Since Linux now supports CFI, it will be a good idea to fix mismatched return type for implementation of hooks. Otherwise this might get cought out by CFI and cause a panic. ltq_etop_tx() would return either NETDEV_TX_BUSY or NETDEV_TX_OK, so change the return type to netdev_tx_t directly. Signed-off-by: GUO Zihua Link: https://lore.kernel.org/r/20220902081521.59867-1-guozihua@huawei.com Signed-off-by: Jakub Kicinski --- diff --git a/drivers/net/ethernet/lantiq_etop.c b/drivers/net/ethernet/lantiq_etop.c index 7cedbe1..59aab40 100644 --- a/drivers/net/ethernet/lantiq_etop.c +++ b/drivers/net/ethernet/lantiq_etop.c @@ -470,7 +470,7 @@ ltq_etop_stop(struct net_device *dev) return 0; } -static int +static netdev_tx_t ltq_etop_tx(struct sk_buff *skb, struct net_device *dev) { int queue = skb_get_queue_mapping(skb);