From: Rasmus Villemoes Date: Fri, 26 Mar 2021 15:14:11 +0000 (+0100) Subject: debugfs: drop pointless nul-termination in debugfs_read_file_bool() X-Git-Tag: accepted/tizen/unified/20230118.172025~7415^2~15 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c8a9c285f136f0cc65ac8328cd1710b155ad3df8;p=platform%2Fkernel%2Flinux-rpi.git debugfs: drop pointless nul-termination in debugfs_read_file_bool() simple_read_from_buffer() doesn't care about any bytes in the buffer beyond "available". Making the buffer nul-terminated is therefore completely pointless. Signed-off-by: Rasmus Villemoes Link: https://lore.kernel.org/r/20210326151411.732220-1-linux@rasmusvillemoes.dk Signed-off-by: Greg Kroah-Hartman --- diff --git a/fs/debugfs/file.c b/fs/debugfs/file.c index 686e0ad..9979d98 100644 --- a/fs/debugfs/file.c +++ b/fs/debugfs/file.c @@ -773,7 +773,7 @@ EXPORT_SYMBOL_GPL(debugfs_create_atomic_t); ssize_t debugfs_read_file_bool(struct file *file, char __user *user_buf, size_t count, loff_t *ppos) { - char buf[3]; + char buf[2]; bool val; int r; struct dentry *dentry = F_DENTRY(file); @@ -789,7 +789,6 @@ ssize_t debugfs_read_file_bool(struct file *file, char __user *user_buf, else buf[0] = 'N'; buf[1] = '\n'; - buf[2] = 0x00; return simple_read_from_buffer(user_buf, count, ppos, buf, 2); } EXPORT_SYMBOL_GPL(debugfs_read_file_bool);