From: Jesper Juhl Date: Mon, 1 Aug 2011 21:39:17 +0000 (-0300) Subject: [media] [Resend] viacam: Don't explode if pci_find_bus() returns NULL X-Git-Tag: v3.1-rc6~7^2~2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c8814df3a578895390fe5c05a76328d8d111ed25;p=profile%2Fivi%2Fkernel-adaptation-intel-automotive.git [media] [Resend] viacam: Don't explode if pci_find_bus() returns NULL In the unlikely case that pci_find_bus() should return NULL viacam_serial_is_enabled() is going to dereference a NULL pointer and blow up. Better safe than sorry, so be defensive and check the pointer. Signed-off-by: Jesper Juhl Acked-by: Jonathan Corbet Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/video/via-camera.c b/drivers/media/video/via-camera.c index 85d3048..bb7f17f 100644 --- a/drivers/media/video/via-camera.c +++ b/drivers/media/video/via-camera.c @@ -1332,6 +1332,8 @@ static __devinit bool viacam_serial_is_enabled(void) struct pci_bus *pbus = pci_find_bus(0, 0); u8 cbyte; + if (!pbus) + return false; pci_bus_read_config_byte(pbus, VIACAM_SERIAL_DEVFN, VIACAM_SERIAL_CREG, &cbyte); if ((cbyte & VIACAM_SERIAL_BIT) == 0)