From: Axel Lin Date: Fri, 22 Feb 2013 00:44:00 +0000 (-0800) Subject: drivers/video/backlight/88pm860x_bl.c: add missing of_node_put() X-Git-Tag: upstream/snapshot3+hdmi~5683^2~61 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c84c383366bcb1025b03a82e5ebcf9f1c645ec68;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git drivers/video/backlight/88pm860x_bl.c: add missing of_node_put() of_find_node_by_name() returns a node pointer with refcount incremented, use of_node_put() on it when done. of_find_node_by_name() will call of_node_put() against the node pass to from parameter, thus we also need to call of_node_get(from) before calling of_find_node_by_name(). Signed-off-by: Axel Lin Cc: Jingoo Han Cc: Haojian Zhuang Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/drivers/video/backlight/88pm860x_bl.c b/drivers/video/backlight/88pm860x_bl.c index c072ed9..2cd6350 100644 --- a/drivers/video/backlight/88pm860x_bl.c +++ b/drivers/video/backlight/88pm860x_bl.c @@ -165,8 +165,10 @@ static int pm860x_backlight_dt_init(struct platform_device *pdev, struct pm860x_backlight_data *data, char *name) { - struct device_node *nproot = pdev->dev.parent->of_node, *np; + struct device_node *nproot, *np; int iset = 0; + + nproot = of_node_get(pdev->dev.parent->of_node); if (!nproot) return -ENODEV; nproot = of_find_node_by_name(nproot, "backlights"); @@ -184,6 +186,7 @@ static int pm860x_backlight_dt_init(struct platform_device *pdev, break; } } + of_node_put(nproot); return 0; } #else