From: Wei Yongjun Date: Wed, 30 Jul 2014 00:04:12 +0000 (+0800) Subject: ASoC: sirf-audio-codec: Fix return value check in sirf_audio_codec_driver_probe() X-Git-Tag: v4.14-rc1~6776^2~37^2~3^3 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c8448051a5e7fda464486eaf5a4ef0c5b6d96673;p=platform%2Fkernel%2Flinux-rpi.git ASoC: sirf-audio-codec: Fix return value check in sirf_audio_codec_driver_probe() In case of error, the function devm_ioremap_resource() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Signed-off-by: Wei Yongjun Signed-off-by: Mark Brown --- diff --git a/sound/soc/codecs/sirf-audio-codec.c b/sound/soc/codecs/sirf-audio-codec.c index d90cb0f..06ba492 100644 --- a/sound/soc/codecs/sirf-audio-codec.c +++ b/sound/soc/codecs/sirf-audio-codec.c @@ -471,8 +471,8 @@ static int sirf_audio_codec_driver_probe(struct platform_device *pdev) mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0); base = devm_ioremap_resource(&pdev->dev, mem_res); - if (base == NULL) - return -ENOMEM; + if (IS_ERR(base)) + return PTR_ERR(base); sirf_audio_codec->regmap = devm_regmap_init_mmio(&pdev->dev, base, &sirf_audio_codec_regmap_config);