From: Sarah Sharp <sarah.a.sharp@linux.intel.com>
Date: Thu, 30 Apr 2009 02:06:36 +0000 (-0700)
Subject: USB: xhci: drop spinlock in xhci_urb_enqueue() error path.
X-Git-Tag: v2.6.31-rc1~304^2~8
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c7959fb265d8d5e00eb6d30717eb63e6189a1f07;p=profile%2Fivi%2Fkernel-adaptation-intel-automotive.git

USB: xhci: drop spinlock in xhci_urb_enqueue() error path.

Make sure the error path in xhci_urb_enqueue() releases the spinlock
before it returns.  Reported by Oliver in
	http://marc.info/?l=linux-usb&m=124091637311832&w=2

Reported-by: Oliver Neukum <oliver@neukum.org>
Signed-off-by: Sarah Sharp <sarah.a.sharp@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---

diff --git a/drivers/usb/host/xhci-hcd.c b/drivers/usb/host/xhci-hcd.c
index 57aed12..c6b9219 100644
--- a/drivers/usb/host/xhci-hcd.c
+++ b/drivers/usb/host/xhci-hcd.c
@@ -591,7 +591,8 @@ int xhci_urb_enqueue(struct usb_hcd *hcd, struct urb *urb, gfp_t mem_flags)
 	if (!xhci->devs || !xhci->devs[slot_id]) {
 		if (!in_interrupt())
 			dev_warn(&urb->dev->dev, "WARN: urb submitted for dev with no Slot ID\n");
-		return -EINVAL;
+		ret = -EINVAL;
+		goto exit;
 	}
 	if (!test_bit(HCD_FLAG_HW_ACCESSIBLE, &hcd->flags)) {
 		if (!in_interrupt())