From: Youngjae Shin Date: Fri, 10 Apr 2020 03:11:38 +0000 (+0900) Subject: fix coverity errors X-Git-Tag: submit/tizen/20200410.031404^0 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c7825eac413246fc12351a72ec4389b923de319e;p=platform%2Fcore%2Fsystem%2Fmodes.git fix coverity errors --- diff --git a/supervisor/Action.cpp b/supervisor/Action.cpp index 3581f4b..fc85b5a 100644 --- a/supervisor/Action.cpp +++ b/supervisor/Action.cpp @@ -21,13 +21,13 @@ MODES_NAMESPACE_USE; Action::Action() - : isChanged(false), type(SYNC), plugin(nullptr), piAction(nullptr), stopOnErr(false), restriction(NONE), locked(false) + : isChanged(false), type(SYNC), life(PERMANENT), plugin(nullptr), piAction(nullptr), stopOnErr(false), restriction(NONE), locked(false) { } Action::Action(const std::string &name) - : ruleName(name), isChanged(false), type(SYNC), plugin(nullptr), piAction(nullptr), stopOnErr(false), restriction(NONE), locked(false) + : ruleName(name), isChanged(false), type(SYNC), life(PERMANENT), plugin(nullptr), piAction(nullptr), stopOnErr(false), restriction(NONE), locked(false) { } diff --git a/unittest/modes_test_client.cpp b/unittest/modes_test_client.cpp index 66f76e1..bc95108 100644 --- a/unittest/modes_test_client.cpp +++ b/unittest/modes_test_client.cpp @@ -20,6 +20,7 @@ #include "common/definitions.h" #define CREATED_MODE_NAME "created" + class ClientTest : public ::testing::Test { protected: void SetUp() override @@ -119,7 +120,9 @@ TEST_F(ClientTest, registerMode) g_idle_add(registerModeIdler, NULL); g_main_loop_run(loop); EXPECT_EQ(MODES_ERROR_NONE, result); - remove(MODES_CUSTOM_MODE_DEFAULT_DIR "/tizen_" CREATED_MODE_NAME "_mode.xml"); + if (0 != remove(MODES_CUSTOM_MODE_DEFAULT_DIR "/tizen_" CREATED_MODE_NAME "_mode.xml")) { + std::cout << "remove() Fail :" << MODES_CUSTOM_MODE_DEFAULT_DIR "/tizen_" CREATED_MODE_NAME "_mode.xml" << "errno = " << errno << std::endl; + } } TEST_F(ClientTest, undoModeEx1)