From: Marek Olšák Date: Sat, 14 May 2022 07:55:34 +0000 (-0400) Subject: Revert "radeonsi/gfx11: limit MSAA color buffers to the RGBA channel order" X-Git-Tag: upstream/22.3.5~8757 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c74d85434866f6340866940d8a07db70a28de063;p=platform%2Fupstream%2Fmesa.git Revert "radeonsi/gfx11: limit MSAA color buffers to the RGBA channel order" This reverts commit 54d85700a12aa33d185e147c2d5c794ba54b7a11. It's an LLVM bug. If you disable AMDGPUImageIntrinsicOptimizer in LLVM, MSAA is fixed. There is no LLVM command line option to disable it from Mesa. Reviewed-by: Mihai Preda Reviewed-by: Pierre-Eric Pelloux-Prayer Part-of: --- diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index 53dd6fc..015cb27 100644 --- a/src/gallium/drivers/radeonsi/si_state.c +++ b/src/gallium/drivers/radeonsi/si_state.c @@ -2452,16 +2452,6 @@ static bool si_is_format_supported(struct pipe_screen *screen, enum pipe_format if (sample_count > max_eqaa_samples || storage_sample_count > max_samples) return false; } - - /* Gfx11: BGRA doesn't work with samples >= 4. Only allow R/0/1 to be the first - * component for simplicity. - */ - if (sscreen->info.gfx_level >= GFX11 && - !util_format_is_depth_or_stencil(format) && - util_format_description(format)->swizzle[0] != PIPE_SWIZZLE_X && - util_format_description(format)->swizzle[0] != PIPE_SWIZZLE_0 && - util_format_description(format)->swizzle[0] != PIPE_SWIZZLE_1) - return false; } if (usage & (PIPE_BIND_SAMPLER_VIEW | PIPE_BIND_SHADER_IMAGE)) {