From: Marijn Suijten Date: Mon, 15 Nov 2021 20:34:57 +0000 (+0100) Subject: backlight: qcom-wled: Provide enabled_strings default for WLED 4 and 5 X-Git-Tag: v6.1-rc5~2280^2~2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c70aefdedb24ec545d0958f17faae3b3a3141d2e;p=platform%2Fkernel%2Flinux-starfive.git backlight: qcom-wled: Provide enabled_strings default for WLED 4 and 5 Only WLED 3 sets a sensible default that allows operating this driver with just qcom,num-strings in the DT; WLED 4 and 5 require qcom,enabled-strings to be provided otherwise enabled_strings remains zero-initialized, resulting in every string-specific register write (currently only the setup and config functions, brightness follows in a future patch) to only configure the zero'th string multiple times. Signed-off-by: Marijn Suijten Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Daniel Thompson Signed-off-by: Lee Jones Link: https://lore.kernel.org/r/20211115203459.1634079-8-marijn.suijten@somainline.org --- diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c index 5c5df5a..f975c1f 100644 --- a/drivers/video/backlight/qcom-wled.c +++ b/drivers/video/backlight/qcom-wled.c @@ -1079,6 +1079,7 @@ static const struct wled_config wled4_config_defaults = { .cabc = false, .external_pfet = false, .auto_detection_enabled = false, + .enabled_strings = {0, 1, 2, 3}, }; static int wled5_setup(struct wled *wled) @@ -1192,6 +1193,7 @@ static const struct wled_config wled5_config_defaults = { .cabc = false, .external_pfet = false, .auto_detection_enabled = false, + .enabled_strings = {0, 1, 2, 3}, }; static const u32 wled3_boost_i_limit_values[] = {