From: Luiz Capitulino Date: Tue, 8 May 2012 17:24:47 +0000 (-0300) Subject: qemu-ga: guest-suspend-disk: don't emit a success response X-Git-Tag: TizenStudio_2.0_p2.3.2~208^2~4076^2~9 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c6fcc10ab31d22e93eb169c451025ac9636ec84b;p=sdk%2Femulator%2Fqemu.git qemu-ga: guest-suspend-disk: don't emit a success response Today, qemu-ga may not be able to emit a success response when guest-suspend-disk completes. This happens because the VM may vanish before qemu-ga is able to emit a response. This semantic is a bit confusing, as it's not clear for clients if they should wait for a response or how they should check for success. This commit solves that problem by changing guest-suspend-disk to never emit a success response and suggests in the documentation what clients could do to check for success. Signed-off-by: Luiz Capitulino Signed-off-by: Michael Roth --- diff --git a/qapi-schema-guest.json b/qapi-schema-guest.json index 1dd3454..88b165c 100644 --- a/qapi-schema-guest.json +++ b/qapi-schema-guest.json @@ -363,17 +363,21 @@ # For the best results it's strongly recommended to have the pm-utils # package installed in the guest. # -# Returns: nothing on success +# This command does NOT return a response on success. There is a high chance +# the command succeeded if the VM exits with a zero exit status or, when +# running with --no-shutdown, by issuing the query-status QMP command to +# to confirm the VM status is "shutdown". However, the VM could also exit +# (or set its status to "shutdown") due to other reasons. +# +# The following errors may be returned: # If suspend to disk is not supported, Unsupported # -# Notes: o This is an asynchronous request. There's no guarantee a response -# will be sent -# o It's strongly recommended to issue the guest-sync command before -# sending commands when the guest resumes +# Notes: It's strongly recommended to issue the guest-sync command before +# sending commands when the guest resumes # # Since: 1.1 ## -{ 'command': 'guest-suspend-disk' } +{ 'command': 'guest-suspend-disk', 'success-response': 'no' } ## # @guest-suspend-ram