From: Simon Glass Date: Sun, 17 Feb 2019 03:24:45 +0000 (-0700) Subject: sandbox: Add a note about the growing state_info struct X-Git-Tag: v2019.04-rc3~13^2~22 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c6d84a30fe4cbfd438cb88d76b1cbb71dda2b2f8;p=platform%2Fkernel%2Fu-boot.git sandbox: Add a note about the growing state_info struct This struct is getting larger and in some cases is being used for things which would be better put into a driver. For example hwspinlock is not used outside of sandbox_hwspinlock.c. Add a note to encourage people to put things elsewhere. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- diff --git a/arch/sandbox/include/asm/state.h b/arch/sandbox/include/asm/state.h index c724827..2d773d3 100644 --- a/arch/sandbox/include/asm/state.h +++ b/arch/sandbox/include/asm/state.h @@ -102,6 +102,15 @@ struct sandbox_state { ulong next_tag; /* Next address tag to allocate */ struct list_head mapmem_head; /* struct sandbox_mapmem_entry */ bool hwspinlock; /* Hardware Spinlock status */ + + /* + * This struct is getting large. + * + * Consider putting test data in driver-private structs, like + * sandbox_pch.c. + * + * If you add new members, please put them above this comment. + */ }; /* Minimum space we guarantee in the state FDT when calling read/write*/