From: Augusto Noronha Date: Tue, 9 Aug 2022 23:52:15 +0000 (-0700) Subject: [lldb] Allow DataFileCache to be constructed with a different policy X-Git-Tag: upstream/17.0.6~36757 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c6c5944d05e81b5c7f48abea22a98389b1204a33;p=platform%2Fupstream%2Fllvm.git [lldb] Allow DataFileCache to be constructed with a different policy Differential Revision: https://reviews.llvm.org/D131531 --- diff --git a/lldb/include/lldb/Core/DataFileCache.h b/lldb/include/lldb/Core/DataFileCache.h index 2dc69f6..300c484 100644 --- a/lldb/include/lldb/Core/DataFileCache.h +++ b/lldb/include/lldb/Core/DataFileCache.h @@ -14,6 +14,7 @@ #include "lldb/Utility/UUID.h" #include "lldb/lldb-forward.h" #include "llvm/ADT/DenseMap.h" +#include "llvm/Support/CachePruning.h" #include "llvm/Support/Caching.h" #include @@ -40,11 +41,18 @@ namespace lldb_private { class DataFileCache { public: - /// Create a data file cache in the directory path that is specified. + /// Create a data file cache in the directory path that is specified, using + /// the specified policy. /// /// Data will be cached in files created in this directory when clients call /// DataFileCache::SetCacheData. - DataFileCache(llvm::StringRef path); + DataFileCache(llvm::StringRef path, + llvm::CachePruningPolicy policy = + DataFileCache::GetLLDBIndexCachePolicy()); + + /// Gets the default LLDB index cache policy, which is controlled by the + /// "LLDBIndexCache" family of settings. + static llvm::CachePruningPolicy GetLLDBIndexCachePolicy(); /// Get cached data from the cache directory for the specified key. /// diff --git a/lldb/source/Core/DataFileCache.cpp b/lldb/source/Core/DataFileCache.cpp index b38adfd..07c6839 100644 --- a/lldb/source/Core/DataFileCache.cpp +++ b/lldb/source/Core/DataFileCache.cpp @@ -19,26 +19,34 @@ using namespace lldb_private; -DataFileCache::DataFileCache(llvm::StringRef path) { - m_cache_dir.SetPath(path); - // Prune the cache based off of the LLDB settings each time we create a cache - // object. - ModuleListProperties &properties = - ModuleList::GetGlobalModuleListProperties(); - llvm::CachePruningPolicy policy; - // Only scan once an hour. If we have lots of debug sessions we don't want - // to scan this directory too often. A timestamp file is written to the - // directory to ensure different processes don't scan the directory too often. - // This setting doesn't mean that a thread will continually scan the cache - // directory within this process. - policy.Interval = std::chrono::hours(1); - // Get the user settings for pruning. - policy.MaxSizeBytes = properties.GetLLDBIndexCacheMaxByteSize(); - policy.MaxSizePercentageOfAvailableSpace = - properties.GetLLDBIndexCacheMaxPercent(); - policy.Expiration = - std::chrono::hours(properties.GetLLDBIndexCacheExpirationDays() * 24); +llvm::CachePruningPolicy DataFileCache::GetLLDBIndexCachePolicy() { + static llvm::CachePruningPolicy policy; + static llvm::once_flag once_flag; + + llvm::call_once(once_flag, []() { + // Prune the cache based off of the LLDB settings each time we create a + // cache object. + ModuleListProperties &properties = + ModuleList::GetGlobalModuleListProperties(); + // Only scan once an hour. If we have lots of debug sessions we don't want + // to scan this directory too often. A timestamp file is written to the + // directory to ensure different processes don't scan the directory too + // often. This setting doesn't mean that a thread will continually scan the + // cache directory within this process. + policy.Interval = std::chrono::hours(1); + // Get the user settings for pruning. + policy.MaxSizeBytes = properties.GetLLDBIndexCacheMaxByteSize(); + policy.MaxSizePercentageOfAvailableSpace = + properties.GetLLDBIndexCacheMaxPercent(); + policy.Expiration = + std::chrono::hours(properties.GetLLDBIndexCacheExpirationDays() * 24); + }); + return policy; +} + +DataFileCache::DataFileCache(llvm::StringRef path, llvm::CachePruningPolicy policy) { + m_cache_dir.SetPath(path); pruneCache(path, policy); // This lambda will get called when the data is gotten from the cache and @@ -311,3 +319,4 @@ llvm::StringRef StringTableReader::Get(uint32_t offset) const { return llvm::StringRef(); return llvm::StringRef(m_data.data() + offset); } +