From: Ilho Kim <ilho159.kim@samsung.com>
Date: Tue, 22 Sep 2020 09:51:10 +0000 (+0900)
Subject: Fix memory leak
X-Git-Tag: submit/tizen/20201027.061339~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c6c2069d01f5ac8979ef31cb5bb6fb0b16194c8b;p=platform%2Fcore%2Fappfw%2Ftpk-backend.git

Fix memory leak

xmlDocPtr allocated by xmlParseFile should be freed

Change-Id: Ife75f38f457ae2d19b680f40ced8440f4b9c4bee
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
---

diff --git a/src/tpk/step/pkgmgr/step_convert_xml.cc b/src/tpk/step/pkgmgr/step_convert_xml.cc
index af824d7..9a1d1a5 100644
--- a/src/tpk/step/pkgmgr/step_convert_xml.cc
+++ b/src/tpk/step/pkgmgr/step_convert_xml.cc
@@ -100,6 +100,8 @@ bool StepConvertXml::ConvertXml(xmlDocPtr doc) {
 
 common_installer::Step::Status StepConvertXml::process() {
   xmlDocPtr doc = xmlParseFile(xml_path_.string().c_str());
+  auto doc_ptr = std::unique_ptr<std::remove_pointer<xmlDocPtr>::type,
+      decltype(xmlFreeDoc)*>(doc, xmlFreeDoc);
   if (!doc) {
     LOG(ERROR) << "Failed to parse xml file";
     return Step::Status::MANIFEST_ERROR;