From: Etienne Bergeron Date: Thu, 21 Jul 2016 14:55:17 +0000 (+0000) Subject: [compiler-rt] Disable some unittests on windows that rely on shell command X-Git-Tag: llvmorg-4.0.0-rc1~14624 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c6b096572e33fc64d2cc3c24ebce31d5da630be1;p=platform%2Fupstream%2Fllvm.git [compiler-rt] Disable some unittests on windows that rely on shell command Summary: These unittests are not running on windows because they are using incorrect commands. They were not failing on 32-bits because there is a requirement: asan-64-bits. ``` $ "nm" "C:\src\llvm\ninja64\projects\compiler-rt\test\asan\X86_64WindowsConfig\TestCases\Output\no_asan_gen_globals.c.tmp.exe" # command stderr: 'nm': command not found error: command failed with exit status: 127 ``` ``` $ "rm" "-rf" "C:\src\llvm\ninja64\projects\compiler-rt\test\asan\X86_64WindowsConfig\TestCases\Output/coverage-tracing" $ "mkdir" "C:\src\llvm\ninja64\projects\compiler-rt\test\asan\X86_64WindowsConfig\TestCases\Output/coverage-tracing" $ "A=x" # command stderr: 'A=x': command not found error: command failed with exit status: 127 ``` ``` $ "DIR=C:\src\llvm\ninja64\projects\compiler-rt\test\asan\X86_64WindowsConfig\TestCases\Output/coverage-order-pcs" # command stderr: 'DIR=C:\\src\\llvm\\ninja64\\projects\\compiler-rt\\test\\asan\\X86_64WindowsConfig\\TestCases\\Output/coverage-order-pcs': command not found error: command failed with exit status: 127 ``` Reviewers: rnk Subscribers: tberghammer, llvm-commits, danalbert, wang0109, srhines, kubabrecka, chrisha Differential Revision: https://reviews.llvm.org/D22612 llvm-svn: 276290 --- diff --git a/compiler-rt/test/asan/TestCases/no_asan_gen_globals.c b/compiler-rt/test/asan/TestCases/Posix/no_asan_gen_globals.c similarity index 99% rename from compiler-rt/test/asan/TestCases/no_asan_gen_globals.c rename to compiler-rt/test/asan/TestCases/Posix/no_asan_gen_globals.c index 2b13dea..c686f83 100644 --- a/compiler-rt/test/asan/TestCases/no_asan_gen_globals.c +++ b/compiler-rt/test/asan/TestCases/Posix/no_asan_gen_globals.c @@ -2,7 +2,6 @@ // XFAIL: android // FIXME: http://llvm.org/bugs/show_bug.cgi?id=22682 // REQUIRES: asan-64-bits -// // Make sure __asan_gen_* strings do not end up in the symbol table. // RUN: %clang_asan %s -o %t.exe diff --git a/compiler-rt/test/asan/TestCases/coverage-order-pcs.cc b/compiler-rt/test/asan/TestCases/coverage-order-pcs.cc index dcab694..e81c9104 100644 --- a/compiler-rt/test/asan/TestCases/coverage-order-pcs.cc +++ b/compiler-rt/test/asan/TestCases/coverage-order-pcs.cc @@ -19,7 +19,7 @@ // // RUN: rm -rf $DIR // Ordering works only in 64-bit mode for now. -// REQUIRES: asan-64-bits +// REQUIRES: asan-64-bits, shell // UNSUPPORTED: android #include diff --git a/compiler-rt/test/asan/TestCases/coverage-tracing.cc b/compiler-rt/test/asan/TestCases/coverage-tracing.cc index b7755f8..278cfb1 100644 --- a/compiler-rt/test/asan/TestCases/coverage-tracing.cc +++ b/compiler-rt/test/asan/TestCases/coverage-tracing.cc @@ -24,7 +24,7 @@ // RUN: not diff b.points bf.points // RUN: rm -rf %T/coverage-tracing // -// REQUIRES: asan-64-bits +// REQUIRES: asan-64-bits, shell // UNSUPPORTED: android #include diff --git a/compiler-rt/test/asan/TestCases/intra-object-overflow.cc b/compiler-rt/test/asan/TestCases/intra-object-overflow.cc index e48a261..4032cc1 100644 --- a/compiler-rt/test/asan/TestCases/intra-object-overflow.cc +++ b/compiler-rt/test/asan/TestCases/intra-object-overflow.cc @@ -4,6 +4,8 @@ // // FIXME: fix 32-bits. // REQUIRES: asan-64-bits +// FIXME: Implement ASan intra-object padding in Clang's MS record layout +// UNSUPPORTED: win32 #include #include class Foo {