From: Sachin Kamat Date: Mon, 19 Nov 2012 09:20:30 +0000 (+0530) Subject: drm/exynos: Fix potential NULL pointer dereference in exynos_drm_encoder.c X-Git-Tag: upstream/snapshot3+hdmi~6189^2~1^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c69d5276704e1a9c771de57c0a2e7b69ea3ea578;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git drm/exynos: Fix potential NULL pointer dereference in exynos_drm_encoder.c Check overlay_ops is not NULL as checked in the previous 'if' condition. Fixes the following smatch error: drivers/gpu/drm/exynos/exynos_drm_encoder.c:509 exynos_drm_encoder_plane_disable() error: we previously assumed 'overlay_ops' could be null (see line 499) Signed-off-by: Sachin Kamat Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- diff --git a/drivers/gpu/drm/exynos/exynos_drm_encoder.c b/drivers/gpu/drm/exynos/exynos_drm_encoder.c index 607231a..f2df06c 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_encoder.c +++ b/drivers/gpu/drm/exynos/exynos_drm_encoder.c @@ -513,6 +513,6 @@ void exynos_drm_encoder_plane_disable(struct drm_encoder *encoder, void *data) * because the setting for disabling the overlay will be updated * at vsync. */ - if (overlay_ops->wait_for_vblank) + if (overlay_ops && overlay_ops->wait_for_vblank) overlay_ops->wait_for_vblank(manager->dev); }