From: Heiner Kallweit Date: Sun, 11 Mar 2018 14:00:37 +0000 (+0100) Subject: net: phy: set link state to down when creating the phy_device X-Git-Tag: v5.15~9146^2~209 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c69851e940bcdaf202d20ca7099145d9b7ec7368;p=platform%2Fkernel%2Flinux-starfive.git net: phy: set link state to down when creating the phy_device Currently the link state is initialized to "up" when the phy_device is being created. This is not consistent with the phy state being initialized to PHY_DOWN. Usually this doen't do any harm because the link state is updated once the PHY reaches state PHY_AN. However e.g. if a LAN port isn't used and the PHY remains down this inconsistency remains and calls to functions like phy_print_status() give false results. Therefore change the initialization to link being down. Signed-off-by: Heiner Kallweit Reviewed-by: Florian Fainelli Signed-off-by: David S. Miller --- diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index 478405e..b285323 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c @@ -374,7 +374,7 @@ struct phy_device *phy_device_create(struct mii_bus *bus, int addr, int phy_id, dev->duplex = -1; dev->pause = 0; dev->asym_pause = 0; - dev->link = 1; + dev->link = 0; dev->interface = PHY_INTERFACE_MODE_GMII; dev->autoneg = AUTONEG_ENABLE;