From: Chris Wilson Date: Tue, 2 Jan 2018 19:25:00 +0000 (+0000) Subject: drm/i915: Assert we do not try to wait on an invalid seqno X-Git-Tag: v4.19~298^2~46^2~838 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c68ce69910e3b292afc138e12725399d3b0fb347;p=platform%2Fkernel%2Flinux-rpi3.git drm/i915: Assert we do not try to wait on an invalid seqno We should never insert the invalid seqno into the wait tree, so assert we do not. Signed-off-by: Chris Wilson Reviewed-by: Michał Winiarski Link: https://patchwork.freedesktop.org/patch/msgid/20180102192500.20364-1-chris@chris-wilson.co.uk --- diff --git a/drivers/gpu/drm/i915/intel_breadcrumbs.c b/drivers/gpu/drm/i915/intel_breadcrumbs.c index 58c624f..86acac0 100644 --- a/drivers/gpu/drm/i915/intel_breadcrumbs.c +++ b/drivers/gpu/drm/i915/intel_breadcrumbs.c @@ -396,6 +396,8 @@ static bool __intel_engine_add_wait(struct intel_engine_cs *engine, bool first, armed; u32 seqno; + GEM_BUG_ON(!wait->seqno); + /* Insert the request into the retirement ordered list * of waiters by walking the rbtree. If we are the oldest * seqno in the tree (the first to be retired), then