From: Esra Altintas Date: Tue, 7 Oct 2014 19:45:55 +0000 (+0300) Subject: staging: speakup: remove jiffies comparison using time_after_eq() in speakup_dtlk.c X-Git-Tag: v4.14-rc1~6283^2~1255 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c65cfb5e5a456759bce8b4986407d95a2d02e8a8;p=platform%2Fkernel%2Flinux-rpi.git staging: speakup: remove jiffies comparison using time_after_eq() in speakup_dtlk.c The following patch fixes the checkpatch.pl warning: WARNING: Comparing jiffies is almost always wrong; prefer time_after, time_before and friends Signed-off-by: Esra Altintas Reviewed-by: Josh Triplett Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/speakup/speakup_dtlk.c b/drivers/staging/speakup/speakup_dtlk.c index d7d5152..4e059ea 100644 --- a/drivers/staging/speakup/speakup_dtlk.c +++ b/drivers/staging/speakup/speakup_dtlk.c @@ -231,7 +231,7 @@ static void do_catch_up(struct spk_synth *synth) if (ch == '\n') ch = PROCSPEECH; spk_out(ch); - if ((jiffies >= jiff_max) && (ch == SPACE)) { + if (time_after_eq(jiffies, jiff_max) && (ch == SPACE)) { spk_out(PROCSPEECH); spin_lock_irqsave(&speakup_info.spinlock, flags); delay_time_val = delay_time->u.n.value;