From: Julia Lawall Date: Wed, 12 Dec 2012 14:22:44 +0000 (+0100) Subject: drivers/pinctrl/pinctrl-at91.c: convert kfree to devm_kfree X-Git-Tag: upstream/snapshot3+hdmi~5928^2~5 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c62b2b3448330ce1056d7730a01db4e19c95cfca;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git drivers/pinctrl/pinctrl-at91.c: convert kfree to devm_kfree The function at91_dt_node_to_map is ultimately called by the function pinctrl_get, which is an exported function. Since it is possible that this function is not called from within a probe function, for safety, the kfree is converted to a devm_kfree, to both free the data and remove it from the device in a failure situation. Acked-by: Jean-Christophe PLAGNIOL-VILLARD Signed-off-by: Julia Lawall Signed-off-by: Linus Walleij --- diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c index c5e7571..bff54bf 100644 --- a/drivers/pinctrl/pinctrl-at91.c +++ b/drivers/pinctrl/pinctrl-at91.c @@ -265,7 +265,7 @@ static int at91_dt_node_to_map(struct pinctrl_dev *pctldev, /* create mux map */ parent = of_get_parent(np); if (!parent) { - kfree(new_map); + devm_kfree(pctldev->dev, new_map); return -EINVAL; } new_map[0].type = PIN_MAP_TYPE_MUX_GROUP;