From: Miaoqian Lin Date: Mon, 24 Jan 2022 12:41:21 +0000 (+0000) Subject: coresight: syscfg: Fix memleak on registration failure in cscfg_create_device X-Git-Tag: v5.15.73~6188 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c61e2fc87f24cae4701f352fe9ecd4c5c143106c;p=platform%2Fkernel%2Flinux-rpi.git coresight: syscfg: Fix memleak on registration failure in cscfg_create_device commit cfa5dbcdd7aece76f3415284569f2f384aff0253 upstream. device_register() calls device_initialize(), according to doc of device_initialize: Use put_device() to give up your reference instead of freeing * @dev directly once you have called this function. To prevent potential memleak, use put_device() for error handling. Signed-off-by: Miaoqian Lin Fixes: 85e2414c518a ("coresight: syscfg: Initial coresight system configuration") Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20220124124121.8888-1-linmq006@gmail.com Signed-off-by: Mathieu Poirier Signed-off-by: Suzuki K Poulose Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/hwtracing/coresight/coresight-syscfg.c b/drivers/hwtracing/coresight/coresight-syscfg.c index 4305456..c30989e 100644 --- a/drivers/hwtracing/coresight/coresight-syscfg.c +++ b/drivers/hwtracing/coresight/coresight-syscfg.c @@ -791,7 +791,7 @@ static int cscfg_create_device(void) err = device_register(dev); if (err) - cscfg_dev_release(dev); + put_device(dev); create_dev_exit_unlock: mutex_unlock(&cscfg_mutex);