From: Nick Clifton Date: Wed, 30 Mar 2016 15:18:04 +0000 (+0100) Subject: Fix compile time warning about comparison between signed and unsigned values. X-Git-Tag: binutils-2_27~949 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c6025a80cc284ae2781278de6f44c672d5077797;p=platform%2Fupstream%2Fbinutils.git Fix compile time warning about comparison between signed and unsigned values. PR target/19880 * config/tc-arm.c (do_t_push_pop): Cast bitmask to unsigned before shifting. --- diff --git a/gas/ChangeLog b/gas/ChangeLog index 4fecbe5..1b48ea4 100644 --- a/gas/ChangeLog +++ b/gas/ChangeLog @@ -1,3 +1,9 @@ +2016-03-30 Nick Clifton + + PR target/19880 + * config/tc-arm.c (do_t_push_pop): Cast bitmask to unsigned before + shifting. + 2016-03-30 Claudiu Zissulescu * testsuite/gas/all/gas.exp: Don't xfail on ARC. diff --git a/gas/config/tc-arm.c b/gas/config/tc-arm.c index bec091c..9c2eef5 100644 --- a/gas/config/tc-arm.c +++ b/gas/config/tc-arm.c @@ -12516,7 +12516,7 @@ do_t_push_pop (void) if (inst.size_req != 4 && (mask & ~0xff) == 0) inst.instruction = THUMB_OP16 (inst.instruction) | mask; else if (inst.size_req != 4 - && (mask & ~0xff) == (1 << (inst.instruction == T_MNEM_push + && (mask & ~0xff) == (1U << (inst.instruction == T_MNEM_push ? REG_LR : REG_PC))) { inst.instruction = THUMB_OP16 (inst.instruction);