From: Sangyoon Jang <jeremy.jang@samsung.com>
Date: Thu, 14 May 2020 06:43:41 +0000 (+0900)
Subject: Fix installing shared/data directory of ReadonlyUpdateInstall/Uninstall
X-Git-Tag: submit/tizen_5.5/20200514.090654~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c5c1e294c4c8fe02e5df1f7882cdf2e615529862;p=platform%2Fcore%2Fappfw%2Ftpk-backend.git

Fix installing shared/data directory of ReadonlyUpdateInstall/Uninstall

Use StepUpdateStorageDirectory and adjust step order just like as Update
mode, because security registration of StepUpdateSecurity overrides
shared_ro flag.

Change-Id: I734a64b736ad915e801e8c803ed12291464edc72
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
---

diff --git a/src/tpk/tpk_installer.cc b/src/tpk/tpk_installer.cc
index 3994b7c..4c3cd8b 100644
--- a/src/tpk/tpk_installer.cc
+++ b/src/tpk/tpk_installer.cc
@@ -614,7 +614,6 @@ void TpkInstaller::ReadonlyUpdateInstallSteps() {
   AddStep<ci::security::StepRevokeTrustAnchor>();
   AddStep<ci::filesystem::StepCopy>();
   AddStep<ci::filesystem::StepCopyTep>();
-  AddStep<ci::filesystem::StepCreateStorageDirectories>();
   AddStep<tpk::filesystem::StepCreateExternalStorageDirectories>();
   AddStep<tpk::filesystem::StepCreateTpkSymbolicLink>();
   AddStep<tpk::filesystem::StepTpkPatchIcons>();
@@ -627,6 +626,7 @@ void TpkInstaller::ReadonlyUpdateInstallSteps() {
       ci::security::StepPrivacyPrivilege::ActionType::Update);
   AddStep<ci::security::StepUpdateSecurity>();
   AddStep<ci::pkgmgr::StepRunParserPlugin>(ci::Plugin::ActionType::Upgrade);
+  AddStep<ci::filesystem::StepUpdateStorageDirectories>();
   AddStep<ci::filesystem::StepChangeOwnershipAndPermission>();
   AddStep<ci::filesystem::StepCreateGlobalAppSymlinks>();
 }
@@ -663,6 +663,7 @@ void TpkInstaller::ReadonlyUpdateUninstallSteps() {
   AddStep<ci::filesystem::StepRemoveUserData>();
   AddStep<ci::configuration::StepSwitchReadonlyMode>();
   AddStep<ci::security::StepUpdateSecurity>();
+  AddStep<ci::filesystem::StepUpdateStorageDirectories>();
   AddStep<ci::pkgmgr::StepRemoveManifest>();
   AddStep<ci::pkgmgr::StepRunParserPlugin>(ci::Plugin::ActionType::Upgrade);
 }