From: Gao Xiang <hsiangkao@linux.alibaba.com>
Date: Mon, 9 Sep 2024 11:13:05 +0000 (+0800)
Subject: erofs-utils: mkfs: fix inaccurate assertion of hardlinks in rebuild mode
X-Git-Tag: v1.8.2~11
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c551dab0b57757607dd27a1ed764e6d3f9e9fdbd;p=platform%2Fupstream%2Ferofs-utils.git

erofs-utils: mkfs: fix inaccurate assertion of hardlinks in rebuild mode

`erofs_parent_inode(inode) == dir` is only true for non-hardlink
inodes and directories.

Only debug builds are impacted.

Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Link: https://lore.kernel.org/r/20240909111305.1850391-1-hsiangkao@linux.alibaba.com
---

diff --git a/lib/inode.c b/lib/inode.c
index d464bc6..bc3cb76 100644
--- a/lib/inode.c
+++ b/lib/inode.c
@@ -1744,7 +1744,8 @@ static int erofs_mkfs_dump_tree(struct erofs_inode *root, bool rebuild,
 				continue;
 
 			if (!erofs_inode_visited(inode)) {
-				DBG_BUGON(rebuild &&
+				DBG_BUGON(rebuild && (inode->i_nlink == 1 ||
+					  S_ISDIR(inode->i_mode)) &&
 					  erofs_parent_inode(inode) != dir);
 				erofs_mark_parent_inode(inode, dir);