From: Cedric Bail <cedric@osg.samsung.com>
Date: Fri, 29 Sep 2017 01:22:32 +0000 (-0700)
Subject: eio: do not copy memory for nothing.
X-Git-Tag: submit/sandbox/upgrade/efl120/20180319.053334~2425
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c549f2c99377eda988676b0eb0d04117101b19a8;p=platform%2Fupstream%2Fefl.git

eio: do not copy memory for nothing.
---

diff --git a/src/lib/eio/efl_io_manager.c b/src/lib/eio/efl_io_manager.c
index e0c9318..4d832df 100644
--- a/src/lib/eio/efl_io_manager.c
+++ b/src/lib/eio/efl_io_manager.c
@@ -417,18 +417,11 @@ EINA_VALUE_STRUCT_DESC_DEFINE(_eina_stat_desc,
                               EINA_VALUE_STRUCT_MEMBER(EINA_VALUE_TYPE_ULONG, Eina_Stat, ctimensec));
 
 static void
-_file_stat_done_cb(void *data, Eio_File *handle EINA_UNUSED, const Eina_Stat *stat)
+_file_stat_done_cb(void *data, Eio_File *handle EINA_UNUSED, const Eina_Stat *st)
 {
-   Eina_Value_Struct value = { _eina_stat_desc(), NULL };
+   const Eina_Value_Struct value = { _eina_stat_desc(), (void*) st };
    Eina_Promise *p = data;
    Eina_Value r = EINA_VALUE_EMPTY;
-   Eina_Stat *cpy = NULL;
-
-   cpy = calloc(1, sizeof (Eina_Stat));
-   if (!cpy) goto on_error;
-
-   memcpy(cpy, stat, sizeof (Eina_Stat));
-   value.memory = cpy;
 
    if (!eina_value_setup(&r, EINA_VALUE_TYPE_STRUCT))
      goto on_error;
@@ -440,7 +433,6 @@ _file_stat_done_cb(void *data, Eio_File *handle EINA_UNUSED, const Eina_Stat *st
    return ;
 
  on_error:
-   free(cpy);
    eina_value_flush(&r);
    eina_promise_reject(p, eina_error_get());
 }