From: Justin Maggard Date: Thu, 28 Jul 2016 17:44:11 +0000 (-0700) Subject: btrfs-progs: fix memory leak with missing device X-Git-Tag: upstream/4.16.1~1426 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c52762b4c6716a97a8b561e019efd7bef395ad2f;p=platform%2Fupstream%2Fbtrfs-progs.git btrfs-progs: fix memory leak with missing device In read_one_chunk(), we may add an empty entry for a missing device. However, this entry wasn't being added to the dev_list, and so it never got freed. Signed-off-by: Justin Maggard Signed-off-by: David Sterba --- diff --git a/volumes.c b/volumes.c index 26bf6c5..a356d74 100644 --- a/volumes.c +++ b/volumes.c @@ -1761,6 +1761,8 @@ static int read_one_chunk(struct btrfs_root *root, struct btrfs_key *key, map->stripes[i].dev = fill_missing_device(devid); printf("warning, device %llu is missing\n", (unsigned long long)devid); + list_add(&map->stripes[i].dev->dev_list, + &root->fs_info->fs_devices->devices); } }