From: Andrei Coardos Date: Tue, 25 Jul 2023 10:25:32 +0000 (+0300) Subject: gpio: lp3943: remove unneeded platform_set_drvdata() call X-Git-Tag: v6.6.7~2081^2~51 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c518e7dc64573e3e3a196e8b79caa4f77c612366;p=platform%2Fkernel%2Flinux-starfive.git gpio: lp3943: remove unneeded platform_set_drvdata() call This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call, to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file. Reviewed-by: Alexandru Ardelean Signed-off-by: Andrei Coardos Reviewed-by: Andy Shevchenko Signed-off-by: Bartosz Golaszewski --- diff --git a/drivers/gpio/gpio-lp3943.c b/drivers/gpio/gpio-lp3943.c index 79edd5d..8e58242 100644 --- a/drivers/gpio/gpio-lp3943.c +++ b/drivers/gpio/gpio-lp3943.c @@ -199,8 +199,6 @@ static int lp3943_gpio_probe(struct platform_device *pdev) lp3943_gpio->chip = lp3943_gpio_chip; lp3943_gpio->chip.parent = &pdev->dev; - platform_set_drvdata(pdev, lp3943_gpio); - return devm_gpiochip_add_data(&pdev->dev, &lp3943_gpio->chip, lp3943_gpio); }