From: Tomoya MORINAGA Date: Thu, 12 Jan 2012 02:27:05 +0000 (+0900) Subject: usb: gadget: pch_udc: Fix disconnect issue X-Git-Tag: v3.4-rc1~184^2~22^2~39^2~42 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c50a3bff0edb0acd49d8033a12ea4668e09a31ad;p=platform%2Fkernel%2Flinux-stable.git usb: gadget: pch_udc: Fix disconnect issue ISSUE: When the driver notifies a gadget of a disconnect event, a system rarely freezes. CAUSE: When the driver calls dev->driver->disconnect(), it is not calling spin_unlock(). Signed-off-by: Tomoya MORINAGA Signed-off-by: Felipe Balbi --- diff --git a/drivers/usb/gadget/pch_udc.c b/drivers/usb/gadget/pch_udc.c index a3fcaae..6a44c92 100644 --- a/drivers/usb/gadget/pch_udc.c +++ b/drivers/usb/gadget/pch_udc.c @@ -2335,8 +2335,11 @@ static void pch_udc_svc_ur_interrupt(struct pch_udc_dev *dev) /* Complete request queue */ empty_req_queue(ep); } - if (dev->driver && dev->driver->disconnect) + if (dev->driver && dev->driver->disconnect) { + spin_unlock(&dev->lock); dev->driver->disconnect(&dev->gadget); + spin_lock(&dev->lock); + } } /**