From: Anna Schumaker Date: Wed, 30 Aug 2023 18:31:31 +0000 (-0400) Subject: pNFS: Fix assignment of xprtdata.cred X-Git-Tag: v6.6.7~2024^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c4a123d2e8c4dc91d581ee7d05c0cd51a0273fab;p=platform%2Fkernel%2Flinux-starfive.git pNFS: Fix assignment of xprtdata.cred The comma at the end of the line was leftover from an earlier refactor of the _nfs4_pnfs_v3_ds_connect() function. This is technically valid C, so the compilers didn't catch it, but if I'm understanding how it works correctly it assigns the return value of rpc_clnt_add_xprtr() to xprtdata.cred. Reported-by: Olga Kornievskaia Fixes: a12f996d3413 ("NFSv4/pNFS: Use connections to a DS that are all of the same protocol family") Signed-off-by: Anna Schumaker --- diff --git a/fs/nfs/pnfs_nfs.c b/fs/nfs/pnfs_nfs.c index a08cfda..afd2391 100644 --- a/fs/nfs/pnfs_nfs.c +++ b/fs/nfs/pnfs_nfs.c @@ -946,7 +946,7 @@ static int _nfs4_pnfs_v4_ds_connect(struct nfs_server *mds_srv, * Test this address for session trunking and * add as an alias */ - xprtdata.cred = nfs4_get_clid_cred(clp), + xprtdata.cred = nfs4_get_clid_cred(clp); rpc_clnt_add_xprt(clp->cl_rpcclient, &xprt_args, rpc_clnt_setup_test_and_add_xprt, &rpcdata);