From: Greg Rutz <greg@gsr-tek.com>
Date: Tue, 12 Mar 2013 03:55:28 +0000 (-0600)
Subject: libvisual: fix improper video frame clear operation
X-Git-Tag: 1.19.3~511^2~5539
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c480bac5b7c9628f97d2459bbde534abd219e5c6;p=platform%2Fupstream%2Fgstreamer.git

libvisual: fix improper video frame clear operation

The current code is memsetting the GstVideoFrame.data address to 0s (which
causes a segfault). This member is actually an array of data buffers (one for
each plane).  This fix iterates over each data plane to clear them all.

https://bugzilla.gnome.org/show_bug.cgi?id=695655
---

diff --git a/ext/libvisual/gstaudiovisualizer.c b/ext/libvisual/gstaudiovisualizer.c
index 1ce76d2..29c45d7 100644
--- a/ext/libvisual/gstaudiovisualizer.c
+++ b/ext/libvisual/gstaudiovisualizer.c
@@ -1126,7 +1126,11 @@ gst_audio_visualizer_chain (GstPad * pad, GstObject * parent,
       gst_video_frame_copy (&outframe, &scope->tempframe);
     } else {
       /* gst_video_frame_clear() or is output frame already cleared */
-      memset (outframe.data, 0, scope->vinfo.size);
+      gint i;
+
+      for (i = 0; i < scope->vinfo.finfo->n_planes; i++) {
+        memset (outframe.data[i], 0, outframe.map[i].size);
+      }
     }
 
     gst_buffer_replace_all_memory (inbuf,