From: Sreerenj Balachandran Date: Thu, 7 Jun 2018 23:30:23 +0000 (-0800) Subject: msdk: vpp: set passthrough from set_caps method for code clarity X-Git-Tag: 1.19.3~507^2~4129 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c4809aa16c0061cb8817ad7bdc12ced615d8ae78;p=platform%2Fupstream%2Fgstreamer.git msdk: vpp: set passthrough from set_caps method for code clarity Call passthrough setting method from set_caps so that msdk initialize subroutine looks more clear. --- diff --git a/sys/msdk/gstmsdkvpp.c b/sys/msdk/gstmsdkvpp.c index 2fd71f4..924f4e9 100644 --- a/sys/msdk/gstmsdkvpp.c +++ b/sys/msdk/gstmsdkvpp.c @@ -901,9 +901,7 @@ gst_msdkvpp_set_passthrough (GstMsdkVPP * thiz) GST_VIDEO_INFO_FORMAT (&thiz->srcpad_info)) passthrough = FALSE; - GST_OBJECT_UNLOCK (thiz); gst_base_transform_set_passthrough (GST_BASE_TRANSFORM (thiz), passthrough); - GST_OBJECT_LOCK (thiz); } static gboolean @@ -979,9 +977,6 @@ gst_msdkvpp_initialize (GstMsdkVPP * thiz) msdk_status_to_string (status)); } - /* set passthrough according to filter operation change */ - gst_msdkvpp_set_passthrough (thiz); - status = MFXVideoVPP_QueryIOSurf (session, &thiz->param, request); if (status < MFX_ERR_NONE) { GST_ERROR_OBJECT (thiz, "VPP Query IO surfaces failed (%s)", @@ -1074,6 +1069,9 @@ gst_msdkvpp_set_caps (GstBaseTransform * trans, GstCaps * caps, if (!gst_msdkvpp_initialize (thiz)) return FALSE; + /* set passthrough according to filter operation change */ + gst_msdkvpp_set_passthrough (thiz); + /* Ensure sinkpad buffer pool */ thiz->sinkpad_buffer_pool = gst_msdkvpp_create_buffer_pool (thiz, GST_PAD_SINK, caps,