From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 2 Dec 2014 12:54:00 +0000 (+0100)
Subject: of: Delete unnecessary check before calling "of_node_put()"
X-Git-Tag: v5.15~16723^2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c46ca3c8310b61d253a39ff1375ea97912794cd1;p=platform%2Fkernel%2Flinux-starfive.git

of: Delete unnecessary check before calling "of_node_put()"

The of_node_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Grant Likely <grant.likely@linaro.org>
---

diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
index 1807a04..844838e 100644
--- a/drivers/of/unittest.c
+++ b/drivers/of/unittest.c
@@ -516,8 +516,7 @@ static void __init of_selftest_changeset(void)
 	/* Make sure node names are constructed correctly */
 	selftest((np = of_find_node_by_path("/testcase-data/changeset/n2/n21")),
 		 "'%s' not added\n", n21->full_name);
-	if (np)
-		of_node_put(np);
+	of_node_put(np);
 
 	mutex_lock(&of_mutex);
 	selftest(!of_changeset_revert(&chgset), "revert failed\n");