From: Konrad Rzeszutek Wilk Date: Mon, 17 Sep 2012 14:20:09 +0000 (-0400) Subject: xen/swiotlb: For early initialization, return zero on success. X-Git-Tag: accepted/tizen/common/20141203.182822~3376^2~43^2~3 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c468bdee28a1cb61d9b7a8ce9859d17dee43b7d7;p=platform%2Fkernel%2Flinux-arm64.git xen/swiotlb: For early initialization, return zero on success. If everything is setup properly we would return -ENOMEM since rc by default is set to that value. Lets not do that and return a proper return code. Note: The reason the early code needs this special treatment is that it SWIOTLB library call does not return anything (and had it failed it would call panic()) - but our function does. Acked-by: Stefano Stabellini Signed-off-by: Konrad Rzeszutek Wilk --- diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c index 7461edb..b70f2d1 100644 --- a/drivers/xen/swiotlb-xen.c +++ b/drivers/xen/swiotlb-xen.c @@ -230,9 +230,10 @@ retry: goto error; } start_dma_addr = xen_virt_to_bus(xen_io_tlb_start); - if (early) + if (early) { swiotlb_init_with_tbl(xen_io_tlb_start, xen_io_tlb_nslabs, verbose); - else + rc = 0; + } else rc = swiotlb_late_init_with_tbl(xen_io_tlb_start, xen_io_tlb_nslabs); return rc; error: