From: Viresh Kumar Date: Fri, 12 Feb 2016 10:38:26 +0000 (+0530) Subject: greybus: raw: Use consistent label names in connection_init() X-Git-Tag: v4.9.8~1233^2~378^2~21^2~690 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c463593c3dbc8d4dcb132538b0116256fa0cc455;p=platform%2Fkernel%2Flinux-rpi3.git greybus: raw: Use consistent label names in connection_init() Some of the labels are named based on what they are going to undo, while others are based on where we failed in connection_init(). Follow only the first type of naming. Signed-off-by: Viresh Kumar Reviewed-by: Johan Hovold Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/greybus/raw.c b/drivers/staging/greybus/raw.c index a6e7959..d2e0281 100644 --- a/drivers/staging/greybus/raw.c +++ b/drivers/staging/greybus/raw.c @@ -174,21 +174,21 @@ static int gb_raw_connection_init(struct gb_connection *connection) cdev_init(&raw->cdev, &raw_fops); retval = cdev_add(&raw->cdev, raw->dev, 1); if (retval) - goto error_cdev; + goto error_remove_ida; raw->device = device_create(raw_class, &connection->bundle->dev, raw->dev, raw, "gb!raw%d", minor); if (IS_ERR(raw->device)) { retval = PTR_ERR(raw->device); - goto error_device; + goto error_del_cdev; } return 0; -error_device: +error_del_cdev: cdev_del(&raw->cdev); -error_cdev: +error_remove_ida: ida_simple_remove(&minors, minor); error_free: