From: Miaohe Lin Date: Wed, 24 Feb 2021 20:09:22 +0000 (-0800) Subject: z3fold: simplify the zhdr initialization code in init_z3fold_page() X-Git-Tag: accepted/tizen/unified/20230118.172025~7741^2~19 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c457cd96f18c7137287700c409d2ae16c6395256;p=platform%2Fkernel%2Flinux-rpi.git z3fold: simplify the zhdr initialization code in init_z3fold_page() We can simplify the zhdr initialization by memset() the zhdr first instead of set struct member to zero one by one. This would also make code more compact and clear. Link: https://lkml.kernel.org/r/20210120085851.16159-1-linmiaohe@huawei.com Signed-off-by: Miaohe Lin Cc: Vitaly Wool Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/mm/z3fold.c b/mm/z3fold.c index 8e53cdf..c1ccf6b 100644 --- a/mm/z3fold.c +++ b/mm/z3fold.c @@ -413,16 +413,10 @@ static struct z3fold_header *init_z3fold_page(struct page *page, bool headless, if (!slots) return NULL; + memset(zhdr, 0, sizeof(*zhdr)); spin_lock_init(&zhdr->page_lock); kref_init(&zhdr->refcount); - zhdr->first_chunks = 0; - zhdr->middle_chunks = 0; - zhdr->last_chunks = 0; - zhdr->first_num = 0; - zhdr->start_middle = 0; zhdr->cpu = -1; - zhdr->foreign_handles = 0; - zhdr->mapped_count = 0; zhdr->slots = slots; zhdr->pool = pool; INIT_LIST_HEAD(&zhdr->buddy);