From: Simon Horman <horms@verge.net.au>
Date: Thu, 25 Feb 2010 13:50:19 +0000 (+0000)
Subject: greth: fall through to common return statement on error
X-Git-Tag: v2.6.34-rc1~233^2~58
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c43491d73ea04277c92a4aa1a7e63ccab4577756;p=platform%2Fkernel%2Flinux-3.10.git

greth: fall through to common return statement on error

There doesn't seem to be any reason to explicitly return
NETDEV_TX_OK as err is set to NETDEV_TX_OK in all cases that
reach this point.

Signed-off-by: Simon Horman <horms@verge.net.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/greth.c b/drivers/net/greth.c
index d75b461..2b9c1cb 100644
--- a/drivers/net/greth.c
+++ b/drivers/net/greth.c
@@ -560,8 +560,6 @@ map_error:
 	if (net_ratelimit())
 		dev_warn(greth->dev, "Could not create TX DMA mapping\n");
 	dev_kfree_skb(skb);
-	return NETDEV_TX_OK;
-
 out:
 	return err;
 }