From: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date: Wed, 18 Jan 2012 14:58:08 +0000 (+0000)
Subject: playbin2: do not try to deactivate an inactive group
X-Git-Tag: RELEASE-0.11.2~2^2~20
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c433ef9b701f48bae2d0268323d4f69972b91c7f;p=platform%2Fupstream%2Fgst-plugins-base.git

playbin2: do not try to deactivate an inactive group

A group may have failed to activate due to an error (for instance,
having set the URI to a non existent location in about-to-finish).

https://bugzilla.gnome.org/show_bug.cgi?id=666395
---

diff --git a/gst/playback/gstplaybin2.c b/gst/playback/gstplaybin2.c
index f8ccb51..e01ff6c 100644
--- a/gst/playback/gstplaybin2.c
+++ b/gst/playback/gstplaybin2.c
@@ -3846,7 +3846,7 @@ save_current_group (GstPlayBin * playbin)
   /* see if there is a current group */
   GST_PLAY_BIN_LOCK (playbin);
   curr_group = playbin->curr_group;
-  if (curr_group && curr_group->valid) {
+  if (curr_group && curr_group->valid && curr_group->active) {
     /* unlink our pads with the sink */
     deactivate_group (playbin, curr_group);
   }