From: Kees Cook Date: Mon, 18 Feb 2013 20:02:34 +0000 (-0800) Subject: libkmod: fix address argument to mmap calls X-Git-Tag: v13~12 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c3e8d269466ab02e4c4a928f9f5af222f1138725;p=platform%2Fupstream%2Fkmod.git libkmod: fix address argument to mmap calls The first argument to mmap should be "NULL" instead of "0". --- diff --git a/libkmod/libkmod-file.c b/libkmod/libkmod-file.c index 219c63b..5313796 100644 --- a/libkmod/libkmod-file.c +++ b/libkmod/libkmod-file.c @@ -255,7 +255,8 @@ static int load_reg(struct kmod_file *file) return -errno; file->size = st.st_size; - file->memory = mmap(0, file->size, PROT_READ, MAP_PRIVATE, file->fd, 0); + file->memory = mmap(NULL, file->size, PROT_READ, MAP_PRIVATE, + file->fd, 0); if (file->memory == MAP_FAILED) return -errno; file->direct = true; diff --git a/libkmod/libkmod-index.c b/libkmod/libkmod-index.c index 516240e..d386f00 100644 --- a/libkmod/libkmod-index.c +++ b/libkmod/libkmod-index.c @@ -801,9 +801,9 @@ struct index_mm *index_mm_open(struct kmod_ctx *ctx, const char *filename, if ((size_t) st.st_size < sizeof(hdr)) goto fail_nommap; - if ((idx->mm = mmap(0, st.st_size, PROT_READ, MAP_PRIVATE, fd, 0)) + if ((idx->mm = mmap(NULL, st.st_size, PROT_READ, MAP_PRIVATE, fd, 0)) == MAP_FAILED) { - ERR(ctx, "mmap(0, %"PRIu64", PROT_READ, %d, MAP_PRIVATE, 0): %m\n", + ERR(ctx, "mmap(NULL, %"PRIu64", PROT_READ, %d, MAP_PRIVATE, 0): %m\n", st.st_size, fd); goto fail_nommap; }