From: Hangyu Hua Date: Wed, 24 Aug 2022 08:26:00 +0000 (+0800) Subject: misc: ocxl: fix possible refcount leak in afu_ioctl() X-Git-Tag: v6.1-rc5~262^2~97 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c3b69ba5114c860d730870c03ab4ee45276e5e35;p=platform%2Fkernel%2Flinux-starfive.git misc: ocxl: fix possible refcount leak in afu_ioctl() eventfd_ctx_put need to be called to put the refcount that gotten by eventfd_ctx_fdget when ocxl_irq_set_handler fails. Fixes: 060146614643 ("ocxl: move event_fd handling to frontend") Acked-by: Frederic Barrat Signed-off-by: Hangyu Hua Link: https://lore.kernel.org/r/20220824082600.36159-1-hbh25y@gmail.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/misc/ocxl/file.c b/drivers/misc/ocxl/file.c index 6777c41..d46dba2 100644 --- a/drivers/misc/ocxl/file.c +++ b/drivers/misc/ocxl/file.c @@ -257,6 +257,8 @@ static long afu_ioctl(struct file *file, unsigned int cmd, if (IS_ERR(ev_ctx)) return PTR_ERR(ev_ctx); rc = ocxl_irq_set_handler(ctx, irq_id, irq_handler, irq_free, ev_ctx); + if (rc) + eventfd_ctx_put(ev_ctx); break; case OCXL_IOCTL_GET_METADATA: