From: Linus Torvalds Date: Wed, 15 Feb 2012 16:05:18 +0000 (-0800) Subject: i387: fix sense of sanity check X-Git-Tag: v3.3-rc4~17 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c38e23456278e967f094b08247ffc3711b1029b2;p=profile%2Fcommon%2Fkernel-common.git i387: fix sense of sanity check The check for save_init_fpu() (introduced in commit 5b1cbac37798: "i387: make irq_fpu_usable() tests more robust") was the wrong way around, but I hadn't noticed, because my "tests" were bogus: the FPU exceptions are disabled by default, so even doing a divide by zero never actually triggers this code at all unless you do extra work to enable them. So if anybody did enable them, they'd get one spurious warning. Signed-off-by: Linus Torvalds --- diff --git a/arch/x86/include/asm/i387.h b/arch/x86/include/asm/i387.h index a295718..727c1dd 100644 --- a/arch/x86/include/asm/i387.h +++ b/arch/x86/include/asm/i387.h @@ -404,7 +404,7 @@ static inline void irq_ts_restore(int TS_state) */ static inline void save_init_fpu(struct task_struct *tsk) { - WARN_ON_ONCE(task_thread_info(tsk)->status & TS_USEDFPU); + WARN_ON_ONCE(!(task_thread_info(tsk)->status & TS_USEDFPU)); preempt_disable(); __save_init_fpu(tsk); stts();