From: Ville Syrjälä Date: Wed, 8 Jan 2020 18:12:39 +0000 (+0200) Subject: drm/i915: Reject DRM_MODE_FLAG_DBLCLK with DVI sinks X-Git-Tag: v5.15~3115^2~7^2~38 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=c35ad31401c079e1fe1bebb1b7d5be2940668676;p=platform%2Fkernel%2Flinux-starfive.git drm/i915: Reject DRM_MODE_FLAG_DBLCLK with DVI sinks The code assumes that DRM_MODE_FLAG_DBLCLK means that we enable the pixel repeat feature. That only works with HDMI since it requires AVI infoframe to signal the information to the sink. Hence even if the mode dotclock would be valid we cannot currently assume that we can just ignore the DBLCLK flag. Reject it for DVI sinks. Signed-off-by: Ville Syrjälä Link: https://patchwork.freedesktop.org/patch/msgid/20200108181242.13650-6-ville.syrjala@linux.intel.com Reviewed-by: Imre Deak --- diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c index 8e9abb2..7dc11ea 100644 --- a/drivers/gpu/drm/i915/display/intel_hdmi.c +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c @@ -2242,8 +2242,11 @@ intel_hdmi_mode_valid(struct drm_connector *connector, if (clock > max_dotclk) return MODE_CLOCK_HIGH; - if (mode->flags & DRM_MODE_FLAG_DBLCLK) + if (mode->flags & DRM_MODE_FLAG_DBLCLK) { + if (!has_hdmi_sink) + return MODE_CLOCK_LOW; clock *= 2; + } if (drm_mode_is_420_only(&connector->display_info, mode)) clock /= 2;